build: add suffix string to docker container #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeseung-bae
changed the title
tkxkd0159
reviewed
May 23, 2024
0Tech
reviewed
May 24, 2024
Yes, It is. It should be deleted.
Thanks for the comment, I'll try this one. |
…swagger generation" This reverts commit 80d61b1.
0Tech
reviewed
May 24, 2024
0Tech
approved these changes
May 24, 2024
jaeseung-bae
changed the title
zemyblue
approved these changes
May 27, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2024
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0)
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2024
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0)
5 tasks
5 tasks
zemyblue
pushed a commit
that referenced
this pull request
May 27, 2024
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0) Co-authored-by: jaeseung-bae <[email protected]>
jaeseung-bae
added a commit
that referenced
this pull request
May 27, 2024
* build: refresh docker container's bound volume for proto and swagger generation * Revert "build: refresh docker container's bound volume for proto and swagger generation" This reverts commit 80d61b1. * build: add current directory as suffix for docker container * chore: update changelog * chore: update pattern (cherry picked from commit 0b92fe0) Co-authored-by: jaeseung-bae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refresh docker container's bound volume which refer to current working directoryWithout refreshing docker container with bound volume location,It doesn't generateproto,swaggerdepending on the current working directory~/Finschia/fisnchia-sdk~/xxx/finschia-sdkMotivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml